fix pgsql import - don't end psql import prematurely, install gzip on sles (for zcat), move sql file path to defaults #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghormoon
force-pushed
the
fix-pgsql-import
branch
4 times, most recently
from
224b87c to
d0df979
Compare
ghormoon
changed the title
ghormoon
force-pushed
the
fix-pgsql-import
branch
from
d0df979 to
8601e0c
Compare
ghormoon
changed the title
|
I've removed the user change, it seems on completely clean VM, it won't build the SLS if it asks for zabbix user (even though it would be used after it would be created) |
ghormoon
changed the title
ghormoon
force-pushed
the
fix-pgsql-import
branch
from
8601e0c to
db9bf8d
Compare
hatifnatt
reviewed
Apr 19, 2021
ghormoon
force-pushed
the
fix-pgsql-import
branch
from
13b31b2 to
fbff3c1
Compare
|
I've rebased on the recent master and split off #151 so we can discuss that specific issue separartely |
ghormoon
changed the title
ghormoon
force-pushed
the
fix-pgsql-import
branch
from
fbff3c1 to
f9c6da0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[fix]A bug fixDoes this PR introduce a
BREAKING CHANGE?No.
Related issues and/or pull requests
#147
Describe the changes you're proposing
head -5 after psql does end the pswl import prematurely with EPIPE, so we need to wait for the command to end.
removed for now, will be in separate pullrequest
when dbroot_user and dbroot_pass is defined, it runs psql as user nobody, which is not guaranteed to exist on all distros. i suggest using zabbix.user, which does exist as we already installed zabbix (so we can use the sql.gz file to import) resolved with the remake of the check, uses zabbix user nowinstall gzip on sles so we are sure zcat exists
move default path to sql file to defaults.yml, so it can be overriden in osfamilymap.yml and not only pillar
redone the check, so it uses psql after it is installed, similarly to what import does, not before.
Pillar / config required to test the proposed changes
remote db with dbroot_user and dbroot_pass set.
Debug log showing how the proposed changes work
removed, most relevant part moved to another pull